Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback #1

Open
wants to merge 2 commits into
base: feedback
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.env
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*
48 changes: 41 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,44 @@
[![Open in Visual Studio Code](https://classroom.github.com/assets/open-in-vscode-c66648af7eb3fe8bc4f294546bfd86ef473780cde1dea487d3c4ff354943c9ae.svg)](https://classroom.github.com/online_ide?assignment_repo_id=7665916&assignment_repo_type=AssignmentRepo)
Week6 Marvel Exercise New Version
# Version 2.0

Özelikle dikkat etmenizi istediğimiz noktalar
### [Click to try version 2 live](https://react-marvel-v2.netlify.app/)

1. Auto complete (Arama alanı için)
2. Detail page (Arama alanında çıkan sonuçlardan birine tıklanınca veya sayfadaki itemlardan birine tıklanınca)
3. Multi Language (İngilizce, Türkçe, Fransızca)
- Character Search Bar
- Character Detail Page
- Translation In 3 Languages

Deadline - 24.04.2022 10:00
Search bar example
![search bar](./forReadme/searchBar.gif)

Translation example
![translation](./forReadme/changeLang.gif)

Character detail page example
![detail page](./forReadme/detailPage.png)

## Version 1.0

### [Click to try version 1 live](https://huseyin-react-marvel-1.netlify.app/)

---

When the site is entered, the necessary data is saved to the session storage. When the page is re-entered, no load is created on the api.

This is what is meant in the image below.

![responsive](./forReadme/marvel-react-full.gif)

---

An example of the responsive work of the site is the following image.

![responsive](./forReadme/marvel-react-responsive.gif)

---

If you want to try the project in your local. Download(or clone) the project. Create .env file in home directory and fill it as below.

```bash
REACT_APP_API_BASE_URL = https://gateway.marvel.com
REACT_APP_PUBLIC_KEY = < your public api key >
REACT_APP_PRIVATE_KEY = < your private api key >
```
Binary file added forReadme/changeLang.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added forReadme/detailPage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added forReadme/marvel-react-full.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added forReadme/marvel-react-responsive.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added forReadme/searchBar.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading