Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add mlflow experiment tracker #450

Merged
merged 55 commits into from
Jul 19, 2024
Merged

[Feature] Add mlflow experiment tracker #450

merged 55 commits into from
Jul 19, 2024

Conversation

debrevitatevitae
Copy link
Collaborator

@debrevitatevitae debrevitatevitae commented Jun 7, 2024

Modify training routines and config to be able to log with ML-Flow.

TODOs:

  • Add MLConfig with username/pw fields which can be set using os.getenv
  • Add StrEnum EXPERIMENT_TRACKER with options TENSORBOARD and MLFLOW
  • Add EXPERIMENT_TRACKER to TrainConfig as tracking_tool
  • Modify train loop to either perform write_tensorboard or write_mlflow depending on the setting of tracking_tool is
  • Add log_params for configs
  • Add log_figures using callbacks
  • Add log_model (overlap with checkpointing?)
  • Test integration with cloud

TODOS @debrevitatevitae:

  • FInalize interface/ features for mlflow tracking
  • Align train_no_grad with train_grad
  • Create a tutorial showcasing mlflow with remote tracking
  • Add tests with mlflow tracking

@debrevitatevitae debrevitatevitae added the feature New feature or request label Jun 7, 2024
@dominikandreasseitz dominikandreasseitz changed the title Tracking with ML-Flow [Feature] Add mlflow experiment tracker to train_grad Jun 7, 2024
@dominikandreasseitz dominikandreasseitz self-assigned this Jun 11, 2024
qadence/ml_tools/utils.py Outdated Show resolved Hide resolved
qadence/ml_tools/utils.py Outdated Show resolved Hide resolved
qadence/ml_tools/train_grad.py Outdated Show resolved Hide resolved
@Roland-djee
Copy link
Collaborator

@dominikandreasseitz @debrevitatevitae Is there review needed here ? Sorry, I lost track a little.

Copy link
Collaborator

@Roland-djee Roland-djee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @debrevitatevitae some cosmetic changes from me.

qadence/ml_tools/config.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
@dominikandreasseitz dominikandreasseitz removed their assignment Jul 4, 2024
@dominikandreasseitz dominikandreasseitz removed their request for review July 4, 2024 08:30
@dominikandreasseitz
Copy link
Collaborator

@debrevitatevitae please try to finish the PR with @Roland-djee's help thanks!

@smitchaudhary smitchaudhary self-assigned this Jul 4, 2024
@debrevitatevitae debrevitatevitae marked this pull request as ready for review July 17, 2024 14:54
@smitchaudhary smitchaudhary removed their assignment Jul 17, 2024
docs/tutorials/qml/mlflow_demonstration.py Outdated Show resolved Hide resolved
qadence/ml_tools/config.py Outdated Show resolved Hide resolved
@Roland-djee Roland-djee self-requested a review July 17, 2024 15:14
Copy link
Collaborator

@Roland-djee Roland-djee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @debrevitatevitae, that's really nice and clean. Some minor comments from me. Happy to approve once addressed.

docs/tutorials/qml/ml_tools.md Outdated Show resolved Hide resolved
docs/tutorials/qml/ml_tools.md Outdated Show resolved Hide resolved
docs/tutorials/qml/ml_tools.md Outdated Show resolved Hide resolved
qadence/ml_tools/printing.py Show resolved Hide resolved
qadence/ml_tools/printing.py Outdated Show resolved Hide resolved
qadence/ml_tools/printing.py Show resolved Hide resolved
qadence/ml_tools/train_grad.py Outdated Show resolved Hide resolved
qadence/ml_tools/printing.py Outdated Show resolved Hide resolved
qadence/ml_tools/train_grad.py Outdated Show resolved Hide resolved
qadence/ml_tools/train_no_grad.py Outdated Show resolved Hide resolved
@smitchaudhary smitchaudhary changed the title [Feature] Add mlflow experiment tracker to train_grad [Feature] Add mlflow experiment tracker Jul 19, 2024
@smitchaudhary smitchaudhary merged commit 5fa4641 into main Jul 19, 2024
8 checks passed
@smitchaudhary smitchaudhary deleted the gt/ml-flow branch July 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants