[Proto] Qadence Tree #278
Closed
[Proto] Qadence Tree #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roland-djee
reviewed
Dec 22, 2023
There was a problem hiding this comment.
Thanks @dominikandreasseitz looks fine as a basis. We should discuss this in the new year on how to expand on this and what kind of functionality we need to include.
| @@ -39,6 +40,29 @@ def unique(x: Iterable) -> List: | |||
| return list(set(x)) | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class ParamContainer: | |||
| circ_vparams: ParamDictType | |||
There was a problem hiding this comment.
Would it make sense to have a single dict like:
vparams = {"circuit": ParamDictType, "observable": ParmaDictType}?
| convert_block_fn = getattr(module, "convert_block") | ||
|
|
||
| except (ImportError, ModuleNotFoundError): | ||
| pass |
There was a problem hiding this comment.
Do we really pass here ?
|
@dominikandreasseitz @Doomsk we should coordinate on how to proceed on this. |
|
Closing given the issue created in the new expression system. |
|
archiving this @Roland-djee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399