Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make window-to-win and restore keep track or window-parameters #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rhuelga
Copy link

@rhuelga rhuelga commented Sep 15, 2014

The window-parameters are not saved, with this modification the parameters contained in the window-persistent-parameters are saved and restored, the way that current-window-configuration does.

@pashinin
Copy link
Owner

Modifying these main structures will make everyones' session files broken (when you read an old session file with a new "win" struct) Can you use parameters? http://workgroups2.readthedocs.org/en/latest/guide/data-structures.html#parameters

@rhuelga
Copy link
Author

rhuelga commented Sep 17, 2014

Now it use win parameters. and the win struct is not modify.

@pashinin
Copy link
Owner

Found another problem...

  1. These parameters (that are saved) may contain complex objects (like #<buffer>). They cannot be saved "as is" like #<buffer> or you will get an error in reading a session file. You can see just a few lines below that I hacked it using (wg-pickel ...) before saving window-next-buffers.
  2. I've met a new object for me for example. #overlay in no buffer. Didn't test anything, maybe it works with wg-pickel. For such sudden errors I used (ignore-errors...)

Have you met these problems?

PS: I know this extension is complex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants