Tf catvars from tlapusan #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mepland
requested changes
Feb 18, 2023
We have an updated the notebooks yet but I do have tutorial I'm working on that uses categoricals. Take a look at I need to fix |
mepland
approved these changes
Feb 18, 2023
…: can't show avg lines as we can for numeric X values
…ered set: can't show avg lines as we can for numeric X values" This reverts commit 6bb0806.
Signed-off-by: Terence Parr <parrt@antlr.org>
…into tf-catvars-from-tlapusan
Signed-off-by: Terence Parr <parrt@antlr.org>
…one value not multiple; normalize to list Signed-off-by: Terence Parr <parrt@antlr.org>
Signed-off-by: Terence Parr <parrt@antlr.org>
…into tf-catvars-from-tlapusan
Signed-off-by: Terence Parr <parrt@antlr.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from @tlapusan, raising exceptions when categorical variable's are used in feature space. I just don't know how to display that at the moment. Popping the version to 2.2.0 to incorporate categorical vars.
Derived from #263
We still need to test the decision notes more, such as when there are lots of levels in the catvars.