-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced ctree_feature_space() that accepts a features arg rather than requiring a model with just 1 or 2 features. #253
Conversation
Signed-off-by: Terence Parr <parrt@antlr.org>
…arg. Signed-off-by: Terence Parr <parrt@antlr.org>
Signed-off-by: Terence Parr <parrt@antlr.org>
Signed-off-by: Terence Parr <parrt@antlr.org>
Signed-off-by: Terence Parr <parrt@antlr.org>
ok, ready for review! I updated sklearn notebook. |
I guess it’s just a count, right? |
Is there a need to reinitialize the decision tree/dtreeviz in case we want to use one and after that two features ? |
I think that is the current behavior, the screenshot looks fine to me? |
I took the code from this PR and there is reinitialization for both classification and regression... @mepland can you check this also please ? |
Signed-off-by: Terence Parr <parrt@antlr.org>
Signed-off-by: Terence Parr <parrt@antlr.org>
Good catch @tlapusan. Sorry about that. cleaned up and resubmitted the notebook so that it creates a single decision tree and model, then reuses that for visualization |
Signed-off-by: Terence Parr <parrt@antlr.org>
Fixed |
…n the number of model features. Signed-off-by: Terence Parr <parrt@antlr.org>
OK, can you guys do one last quick check? If it looks good I can push it for a quick release so I can use it within colab. |
…n the number of model features. Signed-off-by: Terence Parr <parrt@antlr.org>
…n the number of model features. Signed-off-by: Terence Parr <parrt@antlr.org>
…n the number of model features. Signed-off-by: Terence Parr <parrt@antlr.org>
Cool. I will push out a new version today. |
Signed-off-by: Terence Parr parrt@antlr.org