-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve _ctreeviz_univar() #227
Conversation
control the horizontal prediction bars
horizontal 'preds' bars transparent if they wish
The prediction bars look like they are overlapping the bottom of the bar charts. Is this the previous behavior and I just didn't notice? dang. This PR looks fine, but let's leave this open until we can resolve this issue I just raised. Seems like the prediction should go below the axis not on top of the others. |
@parrt 3a72aa2 moves the |
looks great! |
Signed-off-by: Terence Parr <parrt@antlr.org>
@parrt I think we should remove the tesselation_alpha parameter, now that overlaps are impossible. I can do it in a new branch and PR. |
That sounds right. Thank you |
Done, see #235 |
'preds'
key in show param to separately control the horizontal prediction barsValueError
for unrecognizedgtype
rect_edge
color style