Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-482: rename url to uri #457

Merged
merged 1 commit into from
Jun 22, 2023
Merged

FLPATH-482: rename url to uri #457

merged 1 commit into from
Jun 22, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented Jun 22, 2023 •
edited
Loading

What this PR does / why we need it:
rename parameter type "URL" to "URI"
relevant UI merged pr: parodos-dev/backstage-parodos#179
Which issue(s) this PR fixes:
Fixes #482

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@RichardW98 RichardW98 requested a review from rgolangh June 22, 2023 18:01
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 22, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-482 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
rename parameter type "URL" to "URI"
Which issue(s) this PR fixes:
Fixes #482

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from eloycoto June 22, 2023 18:01
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 22, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-482 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
rename parameter type "URL" to "URI"
relevant UI merged pr: parodos-dev/backstage-parodos#179
Which issue(s) this PR fixes:
Fixes #482

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 22, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-482 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
rename parameter type "URL" to "URI"
relevant UI merged pr: parodos-dev/backstage-parodos#179
Which issue(s) this PR fixes:
Fixes #482

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@masayag
Copy link
Collaborator

masayag commented Jun 22, 2023

There are some occurrences of "url" in prebuilttask module. Should they be changed to uri?

→ git grep \\\"url
integration-tests/src/test/java/com/redhat/parodos/flows/SimpleWorkFlowTest.java:                               .singletonList(new ArgumentRequestDTO().key("url").value("http://localhost:8080/actuator/health")));
notification-service/generated/openapi.json:    "url" : "http://localhost:8080",
parodos-model-api/src/main/java/com/redhat/parodos/workflow/parameter/WorkParameterType.java:                           properties.put("format", "url");
parodos-model-api/src/test/java/com/redhat/parodos/workflow/parameter/WorkParameterTypeTest.java:               expectedURLOutput.put("format", "url");
pattern-detection-library/src/test/resources/mavenNodeClue/package.json:    "url": "git@github.com:spring-guides/tut-react-and-spring-data-rest.git"
pattern-detection-library/src/test/resources/mavenNodeClue/package.json:    "url": "https://github.com/spring-guides/tut-react-and-spring-data-rest/issues"
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTask.java:               params.add(WorkParameter.builder().key("url").type(WorkParameterType.TEXT).optional(false).description(
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTask.java:                       url = getRequiredParameterValue("url");
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/project/ProjectAccessRequestWorkFlowTask.java:                    log.info("url: {}", url);
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/rest/RestWorkFlowTask.java:               params.add(WorkParameter.builder().key("url").type(WorkParameterType.TEXT).optional(false)
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/rest/RestWorkFlowTask.java:                       url = getRequiredParameterValue("url");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTaskTest.java:           map.put("url", "theurl");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");

@RichardW98
Copy link
Contributor Author

There are some occurrences of "url" in prebuilttask module. Should they be changed to uri?

→ git grep \\\"url
integration-tests/src/test/java/com/redhat/parodos/flows/SimpleWorkFlowTest.java:                               .singletonList(new ArgumentRequestDTO().key("url").value("http://localhost:8080/actuator/health")));
notification-service/generated/openapi.json:    "url" : "http://localhost:8080",
parodos-model-api/src/main/java/com/redhat/parodos/workflow/parameter/WorkParameterType.java:                           properties.put("format", "url");
parodos-model-api/src/test/java/com/redhat/parodos/workflow/parameter/WorkParameterTypeTest.java:               expectedURLOutput.put("format", "url");
pattern-detection-library/src/test/resources/mavenNodeClue/package.json:    "url": "git@github.com:spring-guides/tut-react-and-spring-data-rest.git"
pattern-detection-library/src/test/resources/mavenNodeClue/package.json:    "url": "https://github.com/spring-guides/tut-react-and-spring-data-rest/issues"
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTask.java:               params.add(WorkParameter.builder().key("url").type(WorkParameterType.TEXT).optional(false).description(
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTask.java:                       url = getRequiredParameterValue("url");
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/project/ProjectAccessRequestWorkFlowTask.java:                    log.info("url: {}", url);
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/rest/RestWorkFlowTask.java:               params.add(WorkParameter.builder().key("url").type(WorkParameterType.TEXT).optional(false)
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/rest/RestWorkFlowTask.java:                       url = getRequiredParameterValue("url");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/jdbc/JdbcWorkFlowTaskTest.java:           map.put("url", "theurl");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");
prebuilt-tasks/src/test/java/com/redhat/parodos/tasks/rest/RestWorkFlowTaskTest.java:           map.put("url", "http://localhost");

I have fixed the "url" in WorkParameterType.java. plesae review.
for the web addresses, I think we can keep the url if that's what it meant to be.

@masayag
Copy link
Collaborator

masayag commented Jun 22, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b69e52f into parodos-dev:main Jun 22, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rgolangh rgolangh Awaiting requested review from rgolangh

@eloycoto eloycoto Awaiting requested review from eloycoto

@masayag masayag Awaiting requested review from masayag

@gabriel-farache gabriel-farache Awaiting requested review from gabriel-farache

@gciavarrini gciavarrini Awaiting requested review from gciavarrini

@anludke anludke Awaiting requested review from anludke

Assignees

@masayag masayag

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichardW98 @openshift-ci-robot @masayag @openshift-merge-robot