Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-473:set additional info for report urls #449

Merged
merged 1 commit into from
Jun 19, 2023
Merged

FLPATH-473:set additional info for report urls #449

merged 1 commit into from
Jun 19, 2023

Conversation

RichardW98
Copy link
Contributor

@RichardW98 RichardW98 commented Jun 19, 2023 •
edited
Loading

What this PR does / why we need it:
add additional info for report links
Which issue(s) this PR fixes :
Fixes #473
Screenshot 2023-06-19 at 12 28 39 PM

example workflowResponse:

[
  {
    "workFlowExecutionId": "30f5b124-db7f-463d-92a6-575457ef2cfb",
    "projectId": "79d23d8c-8e33-409d-b786-8c908e330182",
    "workFlowName": "pendingWithAlertMessageWorkFlow",
    "workStatus": "PENDING",
    "startDate": "2023-06-19 12:46:00.842",
    "endDate": "2023-06-19 12:46:00.879",
    "executeBy": "test",
    "additionalInfos": [
      {
        "key": "Alert message",
        "value": "http://localhost:8080"
      },
      {
        "key": "DoNothing",
        "value": null
      }
    ]
  }
]

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-473 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
add additional info for report links
Which issue(s) this PR fixes :
Fixes #473

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from anludke and nirarg June 19, 2023 16:28
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-473 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
add additional info for report links
Which issue(s) this PR fixes :
Fixes #473
Screenshot 2023-06-19 at 12 28 39 PM

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RichardW98 RichardW98 force-pushed the additional-info branch 2 times, most recently from 7fbe738 to 6995ccb Compare June 19, 2023 16:46
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 19, 2023 •
edited by openshift-ci bot
Loading

@RichardW98: This pull request references FLPATH-473 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
add additional info for report links
Which issue(s) this PR fixes :
Fixes #473
Screenshot 2023-06-19 at 12 28 39 PM

example workflowResponse:

[
 {
   "workFlowExecutionId": "30f5b124-db7f-463d-92a6-575457ef2cfb",
   "projectId": "79d23d8c-8e33-409d-b786-8c908e330182",
   "workFlowName": "pendingWithAlertMessageWorkFlow",
   "workStatus": "PENDING",
   "startDate": "2023-06-19 12:46:00.842",
   "endDate": "2023-06-19 12:46:00.879",
   "executeBy": "test",
   "additionalInfos": [
     {
       "key": "Alert message",
       "value": "http://localhost:8080"
     },
     {
       "key": "DoNothing",
       "value": null
     }
   ]
 }
]

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkliczewski
pkliczewski reviewed Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

...ilt-tasks/src/main/java/com/redhat/parodos/tasks/migrationtoolkit/CreateApplicationTask.java
@@ -71,6 +71,7 @@ else if (result instanceof Result.Success<App> success) {
workContext.put("application", success.value());
taskLogger.logInfoWithSlf4j("MTA client returned success result for application creation: {}",
success.value().name());
addAdditionInfo("VCS branch", repo);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What VCS is standing for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version control system

@masayag
Copy link
Collaborator

masayag commented Jun 19, 2023

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 45cce35 into parodos-dev:main Jun 19, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkliczewski pkliczewski pkliczewski left review comments

@masayag masayag masayag approved these changes

@anludke anludke Awaiting requested review from anludke

@nirarg nirarg Awaiting requested review from nirarg

@eloycoto eloycoto Awaiting requested review from eloycoto

@lshannon lshannon Awaiting requested review from lshannon

@rgolangh rgolangh Awaiting requested review from rgolangh

@wKich wKich Awaiting requested review from wKich

@gciavarrini gciavarrini Awaiting requested review from gciavarrini

Assignees

@masayag masayag

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RichardW98 @openshift-ci-robot @masayag @pkliczewski @openshift-merge-robot