Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

provide the ability to get optional and/or nullable param #443

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Conversation

anludke
Copy link
Contributor

@anludke anludke commented Jun 16, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from lshannon and masayag June 16, 2023 13:04
@anludke anludke requested a review from RichardW98 June 16, 2023 13:04
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichardW98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please fix build issue

@openshift-ci openshift-ci bot removed the lgtm label Jun 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2023

New changes are detected. LGTM label has been removed.

@anludke anludke merged commit 657d9d6 into main Jun 16, 2023
@anludke anludke deleted the FLPATH-418-3 branch June 16, 2023 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants