This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Pass context params from an execution to a workflow execution #433
Merged
openshift-merge-robot
merged 7 commits into
parodos-dev:main
from
masayag:branch-info-for-mta
Jun 15, 2023
Merged
Pass context params from an execution to a workflow execution #433
openshift-merge-robot
merged 7 commits into
parodos-dev:main
from
masayag:branch-info-for-mta
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkliczewski
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
RichardW98
approved these changes
Jun 15, 2023
Enable using arguments from different another execution to use its execution level parameters. This could be used when an assessment workflow gathers inormation and stores it on the context and then when invoking a follow up workflow from the options of that assessment then the requester can pass the execution ID of the assessment. The data flow looks like that: Start -> Asssessment flow -> addParameter "foo": "bar" to WorkContext -> End with option 1 Start -> Workflow from option 1 -> use Workcontext param "foo" -> work -> End The invoking execution ID isn't stored in the DB, it is just a request argument passed in the POST request for invoking a workflow. Signed-off-by: Roy Golan <rgolan@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
branch-info-for-mta
branch
from
June 15, 2023 13:55
807072e
to
8daa39e
Compare
/lgtm |
eloycoto
approved these changes
Jun 15, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto, RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add invokingExecutionId to WorkflowRequestDTO to support context passing
Enable using arguments from another execution to use its execution level parameters.
This could be used when an assessment workflow gathers information and stores it in the context and then when invoking a follow-up workflow from the options of that assessment then the requester can pass the execution ID of the assessment.
The data flow looks like that:
The invoking execution ID isn't stored in the DB, it is just a request argument passed in the POST request for invoking a workflow.
Signed-off-by: Roy Golan rgolan@redhat.com
Signed-off-by: Moti Asayag masayag@redhat.com
FLPATH-458