Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

FLPATH-445: Add support to display alert message for tasks waiting user interference #432

Merged

Conversation

gciavarrini
Copy link
Contributor

What this PR does / why we need it:
Add support to display alert message for tasks waiting user interference as describe in the UI Design

The field alertMessage has been added in WorkStatusResponseDTO class.

See example JSON:

{
  "workFlowExecutionId": "0848cd36-511e-4283-ab97-a9d348acc377",
  "workFlowName": "pendingWithAlertMessageWorkFlow",
  "status": "PENDING",
  "message": null,
  "works": [
    {
      "name": "pendingWithAlertMessageWorkFlowTask",
      "type": "TASK",
      "status": "PENDING",
      "message": null,
      "alertMessage": "[link](http://localhost:8080)"
    },
    {
      "name": "doNothingWorkFlowTask",
      "type": "TASK",
      "status": "COMPLETED",
      "message": null,
      "alertMessage": null
    }
  ]
}

Co-Author: Moti Asayag masayag@redhat.com @masayag

Which issue(s) this PR fixes
Fixes # FLPATH-445

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

gciavarrini and others added 13 commits June 15, 2023 10:28
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Issue states the alert should be added at task level.
Therefore, moved from prds_workflow_execution to
prds_workflow_task_execution and related resources were updated
accordingly to this change.

Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
Signed-off-by: Moti Asayag <masayag@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 15, 2023

@gciavarrini: This pull request references FLPATH-445 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
Add support to display alert message for tasks waiting user interference as describe in the UI Design

The field alertMessage has been added in WorkStatusResponseDTO class.

See example JSON:

{
 "workFlowExecutionId": "0848cd36-511e-4283-ab97-a9d348acc377",
 "workFlowName": "pendingWithAlertMessageWorkFlow",
 "status": "PENDING",
 "message": null,
 "works": [
   {
     "name": "pendingWithAlertMessageWorkFlowTask",
     "type": "TASK",
     "status": "PENDING",
     "message": null,
     "alertMessage": "[link](http://localhost:8080)"
   },
   {
     "name": "doNothingWorkFlowTask",
     "type": "TASK",
     "status": "COMPLETED",
     "message": null,
     "alertMessage": null
   }
 ]
}

Co-Author: Moti Asayag masayag@redhat.com @masayag

Which issue(s) this PR fixes
Fixes # FLPATH-445

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from eloycoto and ydayagi June 15, 2023 09:48
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
@masayag masayag requested a review from RichardW98 June 15, 2023 11:01
@@ -197,6 +197,7 @@
<column name="results" type="varchar(4000)"/>
<column name="status" type="varchar(255)"/>
<column name="message" type="varchar(4000)"/>
<column name="alert_message" type="varchar(4000)"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why it's not type Text in there, but 4000 can be small 😅 but I'm ok to merge it!

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eloycoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit d7ddf76 into parodos-dev:main Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants