This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
add task log & fix report url for mta #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardW98
requested review from
masayag,
eloycoto,
pkliczewski,
gciavarrini and
anludke
masayag
reviewed
Jun 14, 2023
...ilt-tasks/src/main/java/com/redhat/parodos/tasks/migrationtoolkit/CreateApplicationTask.java
Outdated
Show resolved
Hide resolved
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/migrationtoolkit/GetApplicationTask.java
Outdated
Show resolved
Hide resolved
prebuilt-tasks/src/main/java/com/redhat/parodos/tasks/migrationtoolkit/SubmitAnalysisTask.java
Outdated
Show resolved
Hide resolved
masayag
reviewed
Jun 14, 2023
| } | ||
| else if (result instanceof Result.Success<TaskGroup> success) { | ||
| if ("Ready".equals(success.value().state()) && success.value().tasks() != null | ||
| && "Succeeded".equals(success.value().tasks()[0].state())) { | ||
| String reportURL = "%s/hub/applications/%d/bucket/%s".formatted(serverUrl, | ||
| String reportURL = "%s/hub/applications/%d/bucket%s".formatted(serverUrl, |
There was a problem hiding this comment.
not for today, but perhaps this one can use something like URLBuilder to make sure the URL is valid.
|
/lgtm |
masayag
approved these changes
Jun 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add task log & fix report url for mta
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):Fixes #
Change type
Impacted services
Checklist