[FLPATH-424] Return error message with status #411
Conversation
| @@ -47,6 +47,8 @@ public class WorkStatusResponseDTO { | |||
|
|
|||
| private WorkStatus status; | |||
|
|
|||
| private String message; | |||
There was a problem hiding this comment.
@JsonInclude(JsonInclude.Include.NON_EMPTY) ?
There was a problem hiding this comment.
The API contract/spec defines that the response contains a message field, this field shall be present for parodos to fulfil the contract.
This way, the API consumer will not have to worry about non-existing key when processing the response
There was a problem hiding this comment.
I think it can be optional. we can address it later
|
overall, LGTM, but have one question about whether should we include a message in response if it is empty |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds the error message contained in the
Throwableof theWorkReportinto theWorkflowExecutionand saves it to the DB in order to return it when the/statusendpoint is requested; the message is then sent along with the statusWhich issue(s) this PR fixes
fixes #FLPATH-424
Change type
Impacted services
Checklist