FLPATH-405: etag & if-not-modified #402
Conversation
|
@RichardW98: This pull request references FLPATH-405 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -45,6 +46,6 @@ public class WorkFlowStatusResponseDTO { | |||
| private WorkStatus status; | |||
|
|
|||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | |||
| private List<WorkStatusResponseDTO> works; | |||
| private transient List<WorkStatusResponseDTO> works; | |||
There was a problem hiding this comment.
if this one is transient, shouldn't the annotation be changed to @JsonIgnore or should it remain serialized to json?
There was a problem hiding this comment.
we need it to be serialized. sonarlint requires jsonignore or transient, so I have to pick one
There was a problem hiding this comment.
this is dto, so I think transient won't afffect
There was a problem hiding this comment.
i rolled back all the serialzable implement. obj.hashcode() doesn't need it
workflow-service/src/test/java/com/redhat/parodos/project/controller/ProjectControllerTest.java
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What this PR does / why we need it:
return 304 if the value of if-not-modified in request header is equal to etag
Which issue(s) this PR fixes:
Fixes #405
Change type
Impacted services
Checklist