Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

notification-service: cleanup code #360

Merged
merged 1 commit into from
May 22, 2023

Conversation

nirarg
Copy link
Contributor

@nirarg nirarg commented May 22, 2023

What this PR does / why we need it:

Remove unused class - ModelMapperConfig
Use "lombok.Setter"/lombok.getter" instead of declare the functions

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Remove unused class - ModelMapperConfig
Use "lombok.Setter"/lombok.getter" instead of declare the functions
@masayag
Copy link
Collaborator

masayag commented May 22, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: masayag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@masayag
Copy link
Collaborator

masayag commented May 22, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 391ba06 into parodos-dev:main May 22, 2023
@eloycoto
Copy link
Collaborator

@nirarg I need to say that Lombok if you want to add getter/setters you can use @DaTa that adds both of them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants