This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Update Project id format to UUID #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
project_id_uuid_format
branch
from
7448963
to
e6b8b1d
Compare
gciavarrini
reviewed
May 3, 2023
| @@ -167,7 +167,7 @@ public static ProjectResponseDTO getProjectByNameAndDescription(List<ProjectResp | |||
| String projectName, String projectDescription) { | |||
| return projects.stream() | |||
| .filter(prj -> projectName.equals(prj.getName()) && projectDescription.equals(prj.getDescription()) | |||
| && prj.getUsername() == null && !Strings.isNullOrEmpty(prj.getId())) | |||
| && prj.getUsername() == null && prj.getId() == null) | |||
There was a problem hiding this comment.
not sure if it's ok. prj.getId shouldn't be null, no?
There was a problem hiding this comment.
Good catch. Should be the reverse condition.
Signed-off-by: Moti Asayag <masayag@redhat.com>
masayag
force-pushed
the
project_id_uuid_format
branch
from
e6b8b1d
to
82ad582
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirarg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The project ID format is UUID. However, in response, it was defined as a string.
This PR matches the expectations for the format of the project ID by specifying its format to be UUID.
Which issue(s) this PR fixes *:
Partially Fixes #FLPATH-333
Change type
Impacted services
Checklist