This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Authentication: No Authentication when using oauth-proxy #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we choose to use oauth-proxy in front, when openshift is used, we need to disable all the Authentication due to is made in the proxy. Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
pkliczewski
reviewed
Apr 20, 2023
There was a problem hiding this comment.
@eloycoto do you think it makes sense to add an integration test?
|
I already said, having an integration test for this is going to be complicated. We need an entire Openshift instance to be able to test this, and I'm not aware of anything like this in the GH actions. |
|
/lgtm |
RichardW98
approved these changes
Apr 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RichardW98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we choose to use oauth-proxy in front, when openshift is used, we need to disable all the Authentication due to is made in the proxy.