This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Rewrite complex flow #240
Merged
Rewrite complex flow #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gciavarrini
force-pushed
the
rewrite-complex-flow
branch
from
934ce1d
to
5871a30
Compare
pkliczewski
reviewed
Apr 17, 2023
...flow-examples/src/test/java/com/redhat/parodos/examples/integration/utils/ExamplesUtils.java
Outdated
Show resolved
Hide resolved
gciavarrini
force-pushed
the
rewrite-complex-flow
branch
2 times, most recently
from
078dfe6
to
4f56f05
Compare
pkliczewski
reviewed
Apr 17, 2023
workflow-examples/src/test/java/com/redhat/parodos/examples/integration/ComplexWorkFlow.java
Outdated
Show resolved
Hide resolved
|
/lgtm |
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Since we're using a lock, there is no need anymore to stop retrying async call after 100 attempts. Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Merge these two method to avoid code duplication. Add two utility methods to ease the code readability. Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
rewrite-complex-flow
branch
from
531ccd7
to
9c96d76
Compare
|
/lgtm |
pkliczewski
approved these changes
Apr 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pkliczewski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite Complex Flow example available in the bash script using workflow-service SDK