This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Fix: waitProjectStart handle async request
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gciavarrini please rebase on top of #230 |
gciavarrini
force-pushed
the
fix-async-req
branch
2 times, most recently
from
d727ecb
to
4c687a2
Compare
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
fix-async-req
branch
from
22f8ecb
to
b6edb94
Compare
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
eloycoto
approved these changes
Apr 14, 2023
| ApiCallback<List<ProjectResponseDTO>> apiCallback = new ApiCallback<>() { | ||
| AtomicInteger failureCounter = new AtomicInteger(0); | ||
|
|
||
| @Override | ||
| public void onFailure(ApiException e, int statusCode, Map<String, List<String>> responseHeaders) { | ||
| int i = failureCounter.incrementAndGet(); | ||
| if (i >= 100) { | ||
| retry.set(false); | ||
| asyncResult.setError(e.getMessage()); | ||
| signal(); |
There was a problem hiding this comment.
we can return here, and avoid the else thing?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eloycoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve async handling of response and retry mechanism.
AsyncResult<T>is a generic class to be used also in future PRs (e.g. for Complex Flow implementation)Depends on PR #230