This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
pom.xml: use dependecy management #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for pushing this PR. I had a similar thought that we need this exact one to align project-wide dependencies. |
- declare dependecy at the parent, including version and scope - use deps at the module level, with only the group and id - remove conficting declerations, redundant properties Signed-off-by: Roy Golan <rgolan@redhat.com>
rgolangh
force-pushed
the
pom-reusability
branch
from
fb5c4f1
to
6dfb3e9
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pkliczewski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
masayag
reviewed
Apr 4, 2023
| <java.version>11</java.version> | ||
| <junit.version>4.13.1</junit.version> | ||
| <assertj.version>3.17.2</assertj.version> | ||
| <mockito.version>3.5.13</mockito.version> | ||
| <slf4j.version>1.7.30</slf4j.version> | ||
| <lombok.version>1.18.26</lombok.version> |
There was a problem hiding this comment.
just noticed, lombok.version can be pulled to parent pom as well.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roy Golan rgolan@redhat.com