FLPATH-216: Add lombok annotations to service SDK generated files #191
Conversation
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
changed the title
gciavarrini
changed the title
|
@gciavarrini: This pull request references FLPATH-216 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>${lombok.version}</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
isn't this needed for runtime of the SDK?
There was a problem hiding this comment.
This is what Lombok website suggests to configure the dependency:
To set up lombok with any build tool, you have to specify that the lombok dependency is required to compile your source code, but does not need to be present when running/testing/jarring/otherwise deploying your code. Generally this is called a 'provided' dependency.
Do you think that in our project the scope should be different?
There was a problem hiding this comment.
No. Provided makes sense based on the description.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: masayag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add
Lombokannotations@Data @AllArgsConstructor @Builderto workflow-service SDK files.The
UseSDKExampleis updated to demonstrate the use of the new available methods.