add workflow status rest endpoint #138
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anludke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| List<WorkFlowWorkDefinition> masterWorkFlowWorkDefinitions = workFlowWorkRepository | ||
| .findByWorkFlowDefinitionIdOrderByCreateDateAsc(masterWorkFlowDefinition.getId()); | ||
| masterWorkFlowWorkDefinitions.forEach(workFlowWorkDefinition -> { | ||
| if (workFlowWorkDefinition.getWorkDefinitionType().equals(WorkType.WORKFLOW)) { |
There was a problem hiding this comment.
Could you move this to an external method somehow? All these WFdefinitions are getting hard to understand due to the multiple if conditions in there?
Also, all this code is repeated after in the loop
There was a problem hiding this comment.
@eloycoto I believe it's the same comment as @pkliczewski.
| import javax.persistence.Entity; | ||
| import javax.persistence.JoinColumn; | ||
| import javax.persistence.ManyToOne; | ||
| import javax.persistence.*; |
There was a problem hiding this comment.
please expand the asterisk
There was a problem hiding this comment.
Good catch! Fixed
| @@ -130,6 +139,140 @@ public synchronized WorkFlowExecution updateWorkFlow(WorkFlowExecution workFlowE | |||
| return workFlowRepository.save(workFlowExecution); | |||
| } | |||
|
|
|||
| @Override | |||
| public WorkFlowStatusResponseDTO getWorkFlowStatus(UUID workFlowExecutionId) { | |||
There was a problem hiding this comment.
This method seems to be long. Do you think it makes sense to split it?
There was a problem hiding this comment.
@pkliczewski I'll find a way split further.
* avoid null pointer exception when subWorkflow not executed * add tests
|
/lgtm |
No description provided.