This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Flpath 189: Add WorkStatus to WorkFlowResponseDTO and set it before return to user #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
reviewed
Mar 15, 2023
workflow-examples/run_examples.sh
Outdated
| status=$(echo "$response" | jq -r '.workStatus') | ||
| if [[ "$status" == "FAILED" ]]; then | ||
| if "$exitOnFailure"; then | ||
| echo_red "Error: HTTP request failed" >&2 |
There was a problem hiding this comment.
I would use @fail function here tbh
|
/retest |
nirarg
changed the title
TODO: need to check why its failing and re-enable the status check
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: nirarg, pkliczewski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.