Test: Workflow execution controller unit test

Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
parodos-dev · Mar 14, 2023 · ec33bb3 · ec33bb3
1 parent 14996a9
commit ec33bb3
Show file tree

Hide file tree

Showing 2 changed files with 119 additions and 0 deletions.
diff --git a/...ce/src/main/java/com/redhat/parodos/workflow/execution/controller/WorkFlowController.java b/...ce/src/main/java/com/redhat/parodos/workflow/execution/controller/WorkFlowController.java
@@ -68,6 +68,10 @@ public WorkFlowController(WorkFlowService workFlowService) {
 	@PostMapping
 	public ResponseEntity<WorkFlowResponseDTO> execute(@RequestBody @Valid WorkFlowRequestDTO workFlowRequestDTO) {
 		WorkReport workReport = workFlowService.execute(workFlowRequestDTO);
+		if (workReport == null) {
+			return ResponseEntity.status(500).build();
+		}
+
 		return ResponseEntity.ok(WorkFlowResponseDTO.builder()
 				.workFlowExecutionId(WorkContextDelegate.read(workReport.getWorkContext(),
 						WorkContextDelegate.ProcessType.WORKFLOW_EXECUTION, WorkContextDelegate.Resource.ID).toString())

diff --git a/...rc/test/java/com/redhat/parodos/workflow/execution/controller/WorkFlowControllerTest.java b/...rc/test/java/com/redhat/parodos/workflow/execution/controller/WorkFlowControllerTest.java
@@ -0,0 +1,115 @@
+package com.redhat.parodos.workflow.execution.controller;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.redhat.parodos.ControllerMockClient;
+import com.redhat.parodos.workflow.definition.service.WorkFlowDefinitionServiceImpl;
+import com.redhat.parodos.workflow.execution.dto.WorkFlowRequestDTO;
+import com.redhat.parodos.workflow.execution.service.WorkFlowServiceImpl;
+import com.redhat.parodos.workflows.work.WorkContext;
+import com.redhat.parodos.workflows.work.WorkReport;
+import org.hamcrest.Matchers;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
+import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.mock.mockito.MockBean;
+import org.springframework.http.MediaType;
+import org.springframework.test.annotation.DirtiesContext;
+import org.springframework.test.context.ActiveProfiles;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
+
+import java.util.UUID;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+@SpringBootTest
+@DirtiesContext
+@AutoConfigureMockMvc
+@ActiveProfiles("local")
+class WorkFlowControllerTest extends ControllerMockClient {
+
+	@Autowired
+	private MockMvc mockMvc;
+
+	@MockBean
+	private WorkFlowServiceImpl workFlowService;
+
+	@Test
+	public void ExecuteWithoutAuth() throws Exception {
+		// when
+		this.mockMvc.perform(this.getRequestWithInValidCredentials("/api/v1/workflows"))
+				.andExpect(MockMvcResultMatchers.status().isUnauthorized());
+		// then
+		Mockito.verify(this.workFlowService, Mockito.never()).execute(Mockito.any());
+	}
+
+	@Test
+	public void ExecuteWithValidData() throws Exception {
+
+		// given
+		WorkFlowRequestDTO workFlowRequestDTO = new WorkFlowRequestDTO().builder().build();
+		workFlowRequestDTO.setProjectId(UUID.randomUUID().toString());
+		workFlowRequestDTO.setWorkFlowName("FooWorkFlow");
+
+		ObjectMapper objectMapper = new ObjectMapper();
+		String json = objectMapper.writeValueAsString(workFlowRequestDTO);
+
+		WorkReport report = Mockito.mock(WorkReport.class);
+		WorkContext workContext = new WorkContext();
+		workContext.put("WORKFLOW_EXECUTION_ID", UUID.randomUUID().toString());
+		Mockito.when(report.getWorkContext()).thenReturn(workContext);
+		Mockito.when(this.workFlowService.execute(Mockito.any())).thenReturn(report);
+
+		// when
+		this.mockMvc.perform(this.postRequestWithValidCredentials("/api/v1/workflows").content(json))
+				.andExpect(MockMvcResultMatchers.status().isOk())
+				.andExpect(MockMvcResultMatchers.content().contentType(MediaType.APPLICATION_JSON))
+				.andExpect(MockMvcResultMatchers.jsonPath("$.workFlowExecutionId",
+						Matchers.is(workContext.get("WORKFLOW_EXECUTION_ID"))));
+
+		// then
+		Mockito.verify(this.workFlowService, Mockito.times(1)).execute(Mockito.any());
+	}
+
+	@Test
+	public void ServiceExecuteFails() throws Exception {
+		// given
+		WorkFlowRequestDTO workFlowRequestDTO = new WorkFlowRequestDTO().builder().build();
+		workFlowRequestDTO.setProjectId(UUID.randomUUID().toString());
+		workFlowRequestDTO.setWorkFlowName("FooWorkFlow");
+
+		ObjectMapper objectMapper = new ObjectMapper();
+		String json = objectMapper.writeValueAsString(workFlowRequestDTO);
+
+		Mockito.when(this.workFlowService.execute(Mockito.any())).thenReturn(null);
+
+		// when
+		this.mockMvc.perform(this.postRequestWithValidCredentials("/api/v1/workflows").content(json))
+				.andExpect(MockMvcResultMatchers.status().isInternalServerError());
+
+		// then
+		Mockito.verify(this.workFlowService, Mockito.times(1)).execute(Mockito.any());
+	}
+
+	@Test
+	public void TestGetStatusWithoutAuth() throws Exception {
+		// when
+		this.mockMvc
+				.perform(this.getRequestWithInValidCredentials(
+						String.format("/api/v1/workflows/%s/status", UUID.randomUUID().toString())))
+				.andExpect(MockMvcResultMatchers.status().isUnauthorized());
+	}
+
+	@Test
+	public void TestGetStatusWithValidData() throws Exception {
+		// @TODO this test should be completed when the API is implemented
+		// when
+		this.mockMvc
+				.perform(this.getRequestWithValidCredentials(
+						String.format("/api/v1/workflows/%s/status", UUID.randomUUID().toString())))
+				.andExpect(MockMvcResultMatchers.status().isOk());
+	}
+
+}