Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Commit

Permalink
fix: cleanup workflow-properties issues
Browse files Browse the repository at this point in the history
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
  • Loading branch information
eloycoto committed Apr 5, 2023
1 parent c23081a commit 2f730ac
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 12 deletions.
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
package com.redhat.parodos.workflows.workflow;

import lombok.Builder;
import lombok.Data;

@Builder
@Data
public class WorkFlowPropertiesMetadata {

private String version;

public String getVersion() {
return this.version;
}

public void setVersion(String version) {
this.version = version;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
/**
* WorkFlowPropertiesDefinitionDTO
*/
@lombok.Data @lombok.AllArgsConstructor @lombok.Builder
@javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen")
public class WorkFlowPropertiesDefinitionDTO {
public static final String SERIALIZED_NAME_VERSION = "version";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ public ResponseEntity<ProjectResponseDTO> createProject(@Valid @RequestBody Proj
@ApiResponse(responseCode = "401", description = "Unauthorized", content = @Content),
@ApiResponse(responseCode = "403", description = "Forbidden", content = @Content) })
@GetMapping

public ResponseEntity<List<ProjectResponseDTO>> getProjects() {
return ResponseEntity.ok(projectService.getProjects());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
import com.redhat.parodos.workflow.definition.entity.WorkFlowPropertiesDefinition;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;

class WorkFlowPropertiesDefinitionDTOTest {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public void testWorkFlowPropertiesAspectWithValidEnvData() {
WorkFlowPropertiesAspect aspect = new WorkFlowPropertiesAspect();
aspect.env = env;


assertDoesNotThrow(() -> {
Object result = aspect.setProperitesForWorkflow(workflow, properties);
assertNotNull(result);
Expand All @@ -65,7 +64,6 @@ public void testWorkFlowPropertiesAspectWithValidEnvData() {
Mockito.verify(env, Mockito.times(1)).resolvePlaceholders("${git.commit.id}");
}


@Test
public void testWorkFlowPropertiesAspectWithNoValidData() {
// given
Expand Down

0 comments on commit 2f730ac

Please sign in to comment.