Update how to run integration tests command #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
gciavarrini
force-pushed
the
integration-test-fix-env-var
branch
from
7fa02e3
to
800ea84
Compare
masayag
reviewed
Jun 6, 2023
|
|
||
| ```bash | ||
| export SERVER_IP=$(kubectl get nodes kind-control-plane -o json | jq -r '[.status.addresses[] | select(.type=="InternalIP")] | .[0].address') | ||
| ``` | ||
|
|
||
| Finally, use the value of `$SERVER_IP` to configure services hosts in your | ||
| `/etc/hosts` file: |
There was a problem hiding this comment.
@gciavarrini I think this is the missing piece that prevented me from working with kind without port forwarding.
There was a problem hiding this comment.
I didn't have, prior to parodos-dev/parodos#376 , any entry in my /etc/hosts 🤷
masayag
reviewed
Jun 6, 2023
To reflect changes in PR parodos-dev/parodos#376 Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
Signed-off-by: Gloria Ciavarrini <gciavarrini@redhat.com>
gciavarrini
force-pushed
the
integration-test-fix-env-var
branch
from
83227bd
to
91c3009
Compare
|
New changes are detected. LGTM label has been removed. |
masayag
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect changes in PR parodos-dev/parodos#376
Depends on parodos-dev/parodos#376