Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postgresql deployment documentation #16

Closed
wants to merge 1 commit into from
Closed

Conversation

pkliczewski
Copy link
Contributor

This PR fixes spelling mistake in the command and add information about requirement of funcional storage class.

@@ -50,9 +50,13 @@ git clone {{ page.parodos.git_repo }} -b {{ page.parodos.git_branch }}

### Installing Parodos

Before appling the manifests please make sure you have a strageclass configured
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/strageclass/storageclass or even replace with:
[storage class](https://kubernetes.io/docs/concepts/storage/storage-classes/)

Comment on lines 53 to 56
Before appling the manifests please make sure you have a [storage class](https://kubernetes.io/docs/concepts/storage/storage-classes/)
configured and set as default. It is needed to bind persistent volume
claim used by postgresql.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can provide a some suggestion/yaml snippet about the easiest way to configure it to let parodos work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes spelling mistake in the command and add information
about requirement of funcional storage class.
@eloycoto
Copy link
Collaborator

eloycoto commented Jun 1, 2023

TBH, I do not think that we should include the need to postgres in a GSG, I would avoid all to not create any miss-configuration at the user level.

@pkliczewski
Copy link
Contributor Author

TBH, I do not think that we should include the need to postgres in a GSG, I would avoid all to not create any miss-configuration at the user level.

What do you suggest for the users to use in their environments? Any persistence layer needs to be there.

@eloycoto
Copy link
Collaborator

eloycoto commented Jun 1, 2023

As GSG, I would use an internal database as it is for kind, for example. You want to get started, not to complicated with external factors. IMHO

@pkliczewski
Copy link
Contributor Author

@eloycoto I understand your point about getting started guide but we would need to have no recommendation how should be run long term. Internal db is not a solution if you want to survive container crash/restart/eviction.

@masayag
Copy link
Collaborator

masayag commented Jun 6, 2023

@eloycoto @pkliczewski what's the verdict? can this be merged? :-)

@pkliczewski
Copy link
Contributor Author

I think we have much bigger issues with our manifests than making sure to configure storage class. We need to start providing easy way to deploy known version of services. Document how to customize db and ldap settings and provide some getting started guide on how to deploy both. I am ok to close this PR.

@pkliczewski pkliczewski closed this Jun 7, 2023
@masayag masayag deleted the fix branch June 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants