Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

--dev implies --tmp #9938

Merged
2 commits merged into from
Oct 6, 2021
Merged

--dev implies --tmp #9938

2 commits merged into from
Oct 6, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 5, 2021

This changes --dev to imply --tmp when no explicit --base-path is provided.

This changes `--dev` to imply `--tmp` when no explicit `--base-path` is provided.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 5, 2021
@xlc
Copy link
Contributor

xlc commented Oct 5, 2021

this is a breaking change to developers.

@sorpaas sorpaas added B3-apinoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels Oct 5, 2021
@nuke-web3
Copy link
Contributor

nuke-web3 commented Oct 6, 2021

@xlc I will scan the devhub for any issues this may cause - anything else that should be done you think to ensure this is accounted for?

I could imagine that some automated testing/CI might rely on the dev DB to remain between runs. I am not aware of any like this offhand though.

@xlc
Copy link
Contributor

xlc commented Oct 6, 2021

I am good as long as this is included in the release notes and we have docs about how to persistent data if people want to. I personally rely on this behavior because otherwise there could be lot of setup required to test some functionality.

Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a note to --dev about the new behavior

@bkchr bkchr added B5-clientnoteworthy C1-low PR touches the given topic and has a low impact on builders. and removed B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Oct 6, 2021
@bkchr
Copy link
Member Author

bkchr commented Oct 6, 2021

bot merge

@ghost
Copy link

ghost commented Oct 6, 2021

Waiting for commit status.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants