This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use coherent prost crate versions
#9676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoerr
added
A0-please_review
adoerr
changed the title
prost crate versionsprost crate versions
|
syncs_header_only_forks() test fails for Also, how can I re-run a Gitlab task? |
|
this has become slightly more important now that 0.7 does not build with nightly |
KiChjang
approved these changes
Sep 2, 2021
KiChjang
added
A8-mergeoncegreen
and removed
A0-please_review
|
Came here to ask for this and then it happened all by itself. ❤️ |
chevdor
pushed a commit
that referenced
this pull request
Sep 6, 2021
chevdor
pushed a commit
that referenced
this pull request
Sep 6, 2021
chevdor
pushed a commit
that referenced
this pull request
Sep 6, 2021
nuke-web3
pushed a commit
that referenced
this pull request
Sep 6, 2021
chevdor
pushed a commit
that referenced
this pull request
Sep 7, 2021
bkchr
added a commit
that referenced
this pull request
Sep 7, 2021
* RUSTSEC-2021-0076 bump libsecp256k1 (#9391) * RUSTSEC-2021-0076 bump libsecp256k1 libsecp256k1 allows overflowing signatures https://rustsec.org/advisories/RUSTSEC-2021-0076 Changes were made to conform to libsecp256k1 version differences. Closes #9356 * parse_standard_slice() -> parse_overflowing_slice() * Added v2 host function for ecdsa_verify * Add feature tag over helpers * Added ecdsa_verify v2 to test runner * PR feedback - Spaces -> tabs - renamed two helper functions * Fixed imports after rebasing * Bump rest of libsecp256k1 (and libp2p) libp2p also uses libsecp256k1 so it is required to be bumped too, along with all the version difference changes. * Add version2 for ecdsa pubkey recovery * libp2p rebase master fixes * Fix test panic when non Behaviour event is returned * Update bin/node/browser-testing/Cargo.toml * Update primitives/core/src/ecdsa.rs * Update primitives/core/src/ecdsa.rs * Update Cargo.lock Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Use coherent prost crate versions (#9676) * Bump node-browser-testing deps on prost Co-authored-by: Trevor Arjeski <72849114+trevor-crypto@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
cmichi
pushed a commit
that referenced
this pull request
Sep 9, 2021
* RUSTSEC-2021-0076 bump libsecp256k1 (#9391) * RUSTSEC-2021-0076 bump libsecp256k1 libsecp256k1 allows overflowing signatures https://rustsec.org/advisories/RUSTSEC-2021-0076 Changes were made to conform to libsecp256k1 version differences. Closes #9356 * parse_standard_slice() -> parse_overflowing_slice() * Added v2 host function for ecdsa_verify * Add feature tag over helpers * Added ecdsa_verify v2 to test runner * PR feedback - Spaces -> tabs - renamed two helper functions * Fixed imports after rebasing * Bump rest of libsecp256k1 (and libp2p) libp2p also uses libsecp256k1 so it is required to be bumped too, along with all the version difference changes. * Add version2 for ecdsa pubkey recovery * libp2p rebase master fixes * Fix test panic when non Behaviour event is returned * Update bin/node/browser-testing/Cargo.toml * Update primitives/core/src/ecdsa.rs * Update primitives/core/src/ecdsa.rs * Update Cargo.lock Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Use coherent prost crate versions (#9676) * Bump node-browser-testing deps on prost Co-authored-by: Trevor Arjeski <72849114+trevor-crypto@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Andreas Doerr <adoerr@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mixing
0.7.0and0.8.0versions of theprostandprost-buildcrates.Version
0.7.0is causing someclippyCI trouble downstream.No code changes