This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Make ChainExtension trait generic over the runtime #8003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
ChainExtensions
trait to be defined asChainExtension<C: pallet_contracts::Config>
. This is necessary because theChainExtension::call
method has a parameter that is generic over the pallet's configuration. This trait however, only is bound by: frame_system::Config
with no way for theChainExtension
implementer to add additional bounds. Therefore calling into any pallet that is not system or contracts would not work because of the missing bounds on that trait.This PR changes this by giving the implementer the tools to call all runtime functions. A implementation would look like this:
@gregzaitsev : This should fix your problem where you weren't able to pass
T::AccountId
to your pallet.