Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Restructure frame_support::dispatch macro related exports #14817

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented Aug 23, 2023

Partial for paritytech/polkadot-sdk#172
Cumulus companion: paritytech/cumulus#3058
Polkadot companion: paritytech/polkadot#7663

@juangirini juangirini marked this pull request as draft August 23, 2023 14:35
@juangirini juangirini removed request for a team, cheme, athei and jsidorenko August 23, 2023 14:36
@juangirini juangirini marked this pull request as ready for review August 24, 2023 15:01
Base automatically changed from jg/restructure-benchmarking-macro-related-exports to master August 24, 2023 15:32
@juangirini
Copy link
Contributor Author

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: cd "/storage/repositories/substrate" && "git" "merge" "origin/master" "--no-ff" "--no-edit", kill_on_drop: false }' failed with status Some(1); output: no output

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3435741

Comment on lines +34 to +40
/// Private exports that are being used by macros.
///
/// The exports are not stable and should not be relied on.
#[doc(hidden)]
pub mod __private {
pub use sp_runtime::traits::Dispatchable;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need here an extra __private mod. Can we not just put this as well into lib.rs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants