-
Notifications
You must be signed in to change notification settings - Fork 2.6k
expose Kademlia replication factor in node CLI #14374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI and add documentation for the flag, otherwise looks good
The CI pipeline was cancelled due to failure one of the required jobs. |
Any insight in why CI is failing on completely unrelated things? Was CI changed in the meantime and never ran on latest |
Can you merge master and see if that fixes the issue? |
Merge
There's a lot of conflicts I'm not comfortable resolving currently. Also 1298 files changed. I can go ahead and fix stuff that's failing in this PR although it's not related to my changes towards the end of the week. Do you have any other alternatives maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 minus previous comments about docs
the changes you introduced were quite trivial so I'd just take a diff and apply it on top of Substrate master and open a new pull request. |
@altonen will do that, but interested in seeing these changes in Also generally is there strategy for taking master changes and applying them in |
They're most likely going to land in polkadot 0.9.44 but I don't think they'll be backported to another other release. If you need them in 0.9.41, you'd have to do it yourself. That would most likely mean maintaining your own version of 0.9.41 that would point to a Substrate branch where you would've cherry-picked Kademlia changes. |
What does it do?
Exposes setting Kademlia replication factor through node's CLI.
Why?
Default Kademlia replication factor is 20. In environments (testing for example) with less than 20 nodes
AuthorityDiscovery
fails to publish DHT records containing node'sMultiaddrs
. So to makeAuthorityDiscovery
work in test environments it's useful to have option to manually adjust Kademlia replication factor.