This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-transaction-pool: Always use best block to check if we should skip enactment #14285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enactment We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.
bkchr
added
A0-please_review
2 tasks
michalkucharczyk
approved these changes
Jun 2, 2023
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Jun 3, 2023
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Jun 3, 2023
|
@bkchr could you help to backport this to polkadot-v0.9.33 branch? |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
… enactment (paritytech#14285) We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.
crystalin
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jul 19, 2023
… enactment (paritytech#14285) We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.
crystalin
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Jul 19, 2023
… enactment (paritytech#14285) We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.
Agusrodri
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Aug 15, 2023
… enactment (paritytech#14285) We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will calculate the tree route always against the best block and thus, we also should use this one to check if we should skip the checks.