This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sp-api: Make the generated code act based on std in sp-api
#14267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of letting the macro generate code that checks if the `std` feature is enabled, it will now generate code that checks if the `std` feature is enabled for the `sp-api` crate. The old implementation basically required that the crate in which the macro was used, had a `std` feature. Now we don't have this requirement anymore and act accordingly the feature in `sp-api` directly.
bkchr
added
A0-please_review
bkchr
added
the
D3-trivial 🧸
|
bot rebase |
|
Rebased |
sam0x17
approved these changes
May 31, 2023
skunert
reviewed
Jun 1, 2023
| @@ -539,8 +539,6 @@ impl<'a> Fold for ToClientSideDecl<'a> { | |||
| input.supertraits.push(parse_quote!( #crate_::Core<#block_ident> )); | |||
| } | |||
|
|
|||
| // The client side trait is only required when compiling with the feature `std` or `test`. | |||
| input.attrs.push(parse_quote!( #[cfg(any(feature = "std", test))] )); | |||
There was a problem hiding this comment.
Removal of test is intentional?
There was a problem hiding this comment.
Yes, it was basically done to ensure that someone may not declares the std feature for their crate. However, this was not really working as otherwise this pr would not have been required.
skunert
approved these changes
Jun 1, 2023
|
So this doesn't solve #14145 yet it seems? |
No. This wasn't meant to solve this. This needs to be solved as the FRAME macros which also suffer the same problem, as I already told you. The idea of also supporting the |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
…ytech#14267) * sp-api: Make the generated code act based on `std` in `sp-api` Instead of letting the macro generate code that checks if the `std` feature is enabled, it will now generate code that checks if the `std` feature is enabled for the `sp-api` crate. The old implementation basically required that the crate in which the macro was used, had a `std` feature. Now we don't have this requirement anymore and act accordingly the feature in `sp-api` directly. * Missing feature! --------- Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting the macro generate code that checks if the
stdfeature is enabled, it will now generate code that checks if thestdfeature is enabled for thesp-apicrate. The old implementation basically required that the crate in which the macro was used, had astdfeature. Now we don't have this requirement anymore and act accordingly the feature insp-apidirectly.