Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sp-api: Set correct where bound in the generated code #14252

Merged
merged 1 commit into from
May 29, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 29, 2023

The where bound for the create_metadata function wasn't correct. This pr fixes this by using the where bound declared at the type declaration augmented with the manual where bound.

Closes: #14250

The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the
where bound declared at the type declaration augmented with the manual where bound.
@bkchr bkchr added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels May 29, 2023
@bkchr bkchr requested review from lexnv and a team May 29, 2023 09:37
@bkchr bkchr added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label May 29, 2023
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

@bkchr
Copy link
Member Author

bkchr commented May 29, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit ab634fd into master May 29, 2023
@paritytech-processbot paritytech-processbot bot deleted the bkchr-sp-api-metadata-where-bound branch May 29, 2023 10:26
@koushiro
Copy link
Contributor

@bkchr could you cherry-pick this commit into polkadot-v0.9.42 and polkadot-v0.9.43 branch?

bkchr added a commit that referenced this pull request May 29, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the
where bound declared at the type declaration augmented with the manual where bound.
@bkchr
Copy link
Member Author

bkchr commented May 29, 2023

@koushiro done.

@koushiro
Copy link
Contributor

@bkchr I'm using polkadot-v0.9.42 branch, could you update it, please

bkchr added a commit that referenced this pull request May 29, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the
where bound declared at the type declaration augmented with the manual where bound.
@bkchr
Copy link
Member Author

bkchr commented May 29, 2023

Done, sorry I had forgotten to push the branch 🙈

nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the
where bound declared at the type declaration augmented with the manual where bound.
vanderian pushed a commit to gasp-xyz/substrate that referenced this pull request Jul 26, 2023
The where bound for the `create_metadata` function wasn't correct. This pr fixes this by using the
where bound declared at the type declaration augmented with the manual where bound.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime API compilation error after adding Runtime API metadata.
4 participants