Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

RevertCmd: Expose database params via CLI #14182

Merged
merged 2 commits into from
May 21, 2023
Merged

RevertCmd: Expose database params via CLI #14182

merged 2 commits into from
May 21, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 20, 2023

This exposes the database params for the RevertCmd via CLI. So, users can use revert with ParityDb.

Closes: #14046

@bkchr
RevertCmd: Expose database params via CLI
15e4dd2 
This exposes the database params for the `RevertCmd` via CLI. So, users can use `revert` with ParityDb.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). Z0-trivial Writing the issue is of the same difficulty as patching the code. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. labels May 20, 2023
@bkchr bkchr requested a review from a team May 20, 2023 23:52
@michalkucharczyk michalkucharczyk requested a review from a team May 21, 2023 06:27
@ggwpez
Copy link
Member

ggwpez commented May 21, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented May 21, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2866019 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-d46438f7-2174-4620-a014-9e99041c4b07 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 21, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2866019 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2866019/artifacts/download.

@bkchr bkchr merged commit 691894b into master May 21, 2023
@bkchr bkchr deleted the bkchr-revert-cmd-database-params branch May 21, 2023 20:24
gpestana pushed a commit that referenced this pull request May 27, 2023
@bkchr @gpestana
RevertCmd: Expose database params via CLI (#14182)
aa50d06 
* RevertCmd: Expose database params via CLI

This exposes the database params for the `RevertCmd` via CLI. So, users can use `revert` with ParityDb.

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
librelois pushed a commit to moonbeam-foundation/substrate that referenced this pull request Jun 20, 2023
@bkchr @librelois
RevertCmd: Expose database params via CLI (paritytech#14182)
1b83b68 
* RevertCmd: Expose database params via CLI

This exposes the database params for the `RevertCmd` via CLI. So, users can use `revert` with ParityDb.

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
RevertCmd: Expose database params via CLI (paritytech#14182)
866bb68 
* RevertCmd: Expose database params via CLI

This exposes the database params for the `RevertCmd` via CLI. So, users can use `revert` with ParityDb.

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”. Z0-trivial Writing the issue is of the same difficulty as patching the code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

revert command doesn't support --database paritydb
3 participants
@bkchr @ggwpez @michalkucharczyk