Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Manual seal delayed finalize #13999

Merged
merged 14 commits into from
May 2, 2023

Conversation

shunsukew
Copy link
Contributor

@shunsukew shunsukew commented Apr 25, 2023

Solves paritytech/substrate-contracts-node#160
(Before integration to substrate-contract-node, upstream changes in substrate required.)

Adding delayed block finalization for instant block sealing consensus. This is needed for the local development node such as substrate-contract-node, swanky-node.
Instant finalization causes difficulties for frontend development, it is necessary for them to configure the delayed time for block finalization after blocks are imported.

An integration example for actual node can be found here inkdevhub/swanky-node#61.

@shunsukew shunsukew changed the title Manual seal delayed finalize Instant seal delayed finalize Apr 25, 2023
@shunsukew shunsukew changed the title Instant seal delayed finalize Manual seal delayed finalize Apr 25, 2023
@@ -303,6 +321,42 @@ pub async fn run_instant_seal_and_finalize<B, BI, CB, E, C, TP, SC, CIDP, P>(
.await
}

pub async fn run_delayed_finalize<B, CB, C, S>(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs on how to use it. A "real" example would be really nice, but at least saying that you don't set finalize in the command stream etc.

client/consensus/manual-seal/src/lib.rs Outdated Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Outdated Show resolved Hide resolved
@shunsukew
Copy link
Contributor Author

@bkchr Thank you for the review, I updated the corresponding parts.

@shunsukew shunsukew requested a review from bkchr April 25, 2023 08:42
client/consensus/manual-seal/src/lib.rs Outdated Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from a team April 25, 2023 21:47
@bkchr bkchr added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 25, 2023
shunsukew and others added 3 commits April 26, 2023 12:22
@bkchr
Copy link
Member

bkchr commented Apr 27, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

client/consensus/manual-seal/src/lib.rs Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Outdated Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Show resolved Hide resolved
client/consensus/manual-seal/src/lib.rs Show resolved Hide resolved
@shunsukew shunsukew requested a review from melekes May 2, 2023 11:39
@shunsukew
Copy link
Contributor Author

@melekes Thank you for adding comments. updated docs.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bkchr bkchr merged commit c800a2c into paritytech:master May 2, 2023
gpestana pushed a commit that referenced this pull request May 4, 2023
* up

* up

* added test

* remove unncessary dep

* cargo fmt

* cargo fmt

* up

* Update client/consensus/manual-seal/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* fix test

* cargo fmt

* added docs

* updated doc

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* up

* up

* added test

* remove unncessary dep

* cargo fmt

* cargo fmt

* up

* Update client/consensus/manual-seal/src/lib.rs

Co-authored-by: Bastian Köcher <git@kchr.de>

* fix test

* cargo fmt

* added docs

* updated doc

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants