This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
sc-allocator: Do not panic on invalid header pointer #13925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not panic on an invalid header pointer and instead return an error. It is possible that the application modifies the header pointer illegally, but then we should return an error instead of panicking.
bkchr
added
A0-please_review
michalkucharczyk
approved these changes
Apr 14, 2023
ggwpez
reviewed
Apr 15, 2023
| if (u64::from(header_ptr) + u64::from(order.size()) + u64::from(HEADER_SIZE)) > | ||
| mem.size() | ||
| { | ||
| return Err(error("Invalid header pointer detected")) |
There was a problem hiding this comment.
This will poison the heap now. Could you please add this to the test?
I assume this is intended as per doc: Once the allocator has returned an error all subsequent requests will return an error..
There was a problem hiding this comment.
We will abort on the first allocation error any way.
ggwpez
approved these changes
Apr 15, 2023
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1 |
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
We should not panic on an invalid header pointer and instead return an error. It is possible that the application modifies the header pointer illegally, but then we should return an error instead of panicking.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not panic on an invalid header pointer and instead return an error. It is possible that the application modifies the header pointer illegally, but then we should return an error instead of panicking.
Closes: #13924