Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nfts: minor fixes #13576

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Nfts: minor fixes #13576

merged 2 commits into from
Mar 10, 2023

Conversation

jsidorenko
Copy link
Contributor

  1. Renames let MintWitness { owner_of_item } to let MintWitness { owned_item }
    Since we need to specify here item's id, and not the owner
  2. Moves AttributeNamespace into the pallet-nfts types file. At some point, we needed to have the AttributeNamespace defined in a general file in order to use them in nonfungible traits, but later we removed that dependency and could safely put that enum back

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 10, 2023
Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsidorenko review the labels, this is breaking api changes

@jsidorenko jsidorenko added B1-note_worthy Changes should be noted in the release notes F3-breaks_API This PR changes public API; next release should be major. T2-API This PR/Issue is related to APIs. and removed B0-silent Changes should not be mentioned in any release notes labels Mar 10, 2023
@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 8f9b074 into master Mar 10, 2023
@paritytech-processbot paritytech-processbot bot deleted the js/minor-fixes branch March 10, 2023 09:52
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
* Rename owner_of_item to owned_item

* Move AttributeNamespace into the types file
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Rename owner_of_item to owned_item

* Move AttributeNamespace into the types file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit F3-breaks_API This PR changes public API; next release should be major. T2-API This PR/Issue is related to APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants