Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

GetCallIndex trait #13558

Merged
merged 7 commits into from
Mar 22, 2023
Merged

GetCallIndex trait #13558

merged 7 commits into from
Mar 22, 2023

Conversation

kziemianek
Copy link
Contributor

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 7, 2023

User @kziemianek, please sign the CLA here.

@kziemianek kziemianek changed the title WIP: GetCallIndex trait GetCallIndex trait Mar 17, 2023
@kziemianek kziemianek marked this pull request as ready for review March 17, 2023 23:53
@kziemianek kziemianek requested review from ggwpez, kianenigma and KiChjang and removed request for ggwpez, kianenigma and KiChjang March 17, 2023 23:53
@ggwpez
Copy link
Member

ggwpez commented Mar 18, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Mar 18, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2547404 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 98-5a21638a-8ac7-4274-a3fd-0d27977ac757 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 18, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2547404 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2547404/artifacts/download.

@kziemianek
Copy link
Contributor Author

@ggwpez is there anything from my side needed regarding checks? I don't see an option to edit labels here.

@ggwpez
Docs
b9bad2e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
One more test
28c5bbf 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 21, 2023
@ggwpez
Doc
c00f6ed 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
ggwpez approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggwpez ggwpez requested a review from sam0x17 March 21, 2023 16:16
@ggwpez
Copy link
Member

ggwpez commented Mar 21, 2023 •
edited
Loading

is there anything from my side needed regarding checks? I don't see an option to edit labels here.

Yea sorry I am a bit slow currently with all the issues 😅. You dont need to edit them yourself.
But please update the MR description to explain what this MR now does. Otherwise downstream teams will be confused.

sam0x17
sam0x17 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@bkchr
Copy link
Member

bkchr commented Mar 22, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr
Copy link
Member

bkchr commented Mar 22, 2023

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@bkchr
Copy link
Member

bkchr commented Mar 22, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 8bd5741 into paritytech:master Mar 22, 2023
breathx pushed a commit to gear-tech/substrate that referenced this pull request Apr 22, 2023
@kziemianek @ggwpez @breathx
GetCallIndex trait (paritytech#13558)
e5a4e14 
* GetCallIndex trait

* final impl

* ".git/.scripts/commands/fmt/fmt.sh"

* Docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* One more test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@liamaharon liamaharon mentioned this pull request Apr 28, 2023
Open
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@kziemianek @ggwpez @nathanwhit
GetCallIndex trait (paritytech#13558)
682f1c9 
* GetCallIndex trait

* final impl

* ".git/.scripts/commands/fmt/fmt.sh"

* Docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* One more test

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Doc

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang left review comments

@kianenigma kianenigma kianenigma left review comments

@sam0x17 sam0x17 sam0x17 approved these changes

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kziemianek @ggwpez @bkchr @sam0x17 @KiChjang @kianenigma