Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Improve handling of unset StorageVersion #13417

Merged
merged 16 commits into from
May 4, 2023
Merged

Improve handling of unset StorageVersion #13417

merged 16 commits into from
May 4, 2023

Commits on Feb 19, 2023

  1. Improve handling of unset StorageVersion 

    When a user is forgetting to set the storage version in a pallet and calls
`current_storage_version` to compare it against the `on_chain_storage_version` it will now fail to
compile the code. Before the pallet macro just returned `StorageVersion::default()` for
`current_storage_version` leading to potential issues with migrations. Besides that it also checks
in `post_upgrade` that the pallet storage version was upgraded and thus, no migration was missed.
    @bkchr
    bkchr committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    57d5de1 View commit details
    Browse the repository at this point in the history

  2. Use correct Cargo.lock

    @bkchr
    bkchr committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    35ec109 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Fixes

    @bkchr
    bkchr committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    21595de View commit details
    Browse the repository at this point in the history

  2. Fix test

    @bkchr
    bkchr committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    2467c47 View commit details
    Browse the repository at this point in the history

  3. Update frame/support/test/tests/pallet.rs

    @bkchr
    bkchr committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    f0b844b View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Merge remote-tracking branch 'origin/master' into bkchr-something-sto… 

    …rage-version
    @bkchr
    bkchr committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    1732b68 View commit details
    Browse the repository at this point in the history

  2. Ensure we don't set a storage version when the pallet is missing the … 

    …attribute
    @bkchr
    bkchr committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    399af7b View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Fix merge conflict

    @bkchr
    bkchr committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    f4faffc View commit details
    Browse the repository at this point in the history

  2. Update frame/support/procedural/src/pallet/expand/hooks.rs 

    Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
    @bkchr @ruseinov
    bkchr and ruseinov committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cfefade View commit details
    Browse the repository at this point in the history

  3. Update frame/support/procedural/src/pallet/expand/hooks.rs 

    Co-authored-by: Roman Useinov <roman.useinov@gmail.com>
    @bkchr @ruseinov
    bkchr and ruseinov committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    43ee1a0 View commit details
    Browse the repository at this point in the history

  4. Fix compilation

    @bkchr
    bkchr committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    8021dfa View commit details
    Browse the repository at this point in the history

  5. Do not run everything with try-runtime

    @bkchr
    bkchr committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    7f0626b View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Fix test

    @bkchr
    bkchr committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2babce7 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
    @bkchr @ggwpez
    bkchr and ggwpez committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8451fc5 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Fix no-metadata-docs

    @bkchr
    bkchr committed May 3, 2023
    Configuration menu
    Copy the full SHA
    2ff5428 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Merge remote-tracking branch 'origin/master' into bkchr-something-sto… 

    …rage-version
    parity-processbot committed May 4, 2023
    Configuration menu
    Copy the full SHA
    dd3ccd0 View commit details
    Browse the repository at this point in the history