Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[NFTs] Track item's metadata depositor #13124

Merged
merged 9 commits into from
Jan 11, 2023

Conversation

jsidorenko
Copy link
Contributor

As part of the upcoming feature to support the pre-signed claims those would allow to offload of the deposit onto the final NFT's receiver, we need to start tracking the metadata depositor in a similar way as we did for attributes.

@jsidorenko jsidorenko added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. A0-please_review Pull request needs code review. labels Jan 11, 2023
frame/nfts/src/features/attributes.rs Outdated Show resolved Hide resolved
@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

This PR cannot be merged at the moment due to: 3 of 13 required status checks are expected.

processbot expects that the problem will be solved automatically later and so the auto-merge process will be started. You can simply wait for now.

@jsidorenko jsidorenko self-assigned this Jan 11, 2023
@jsidorenko jsidorenko added A0-please_review Pull request needs code review. and removed A0-please_review Pull request needs code review. labels Jan 11, 2023
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for e39130b

@jsidorenko
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 293c1f2 into master Jan 11, 2023
@paritytech-processbot paritytech-processbot bot deleted the js/track-metadata-depositor branch January 11, 2023 13:28
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
* Refactor do_mint()

* Track the depositor of item's metadata

* Revert back the access control

* On collection destroy return the metadata deposit

* Clear the metadata on item burn returning the deposit

* Address comments

* Fix clippy

* Don't return Ok on non-existing attribute removal
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-38/2122/1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants