Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adds custom RPC to staking related calls #13095

Closed
wants to merge 3 commits into from

Conversation

gpestana
Copy link
Contributor

@gpestana gpestana commented Jan 7, 2023

major WIP, open for comments and discussion

Open questions:

  • should the points to balance be part of the staking RPC or should it have its own RPC trait and machinery?
  • should we add the staking_queryNominationsQuota before merging [NPoS] Implements dynamic number of nominators #12970? (nomination quota is T::MaxNominations before having the dynamic nominations quota)

Related to #13069

@gpestana gpestana self-assigned this Jan 7, 2023
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 7, 2023
@gpestana gpestana added J2-unconfirmed Issue might be valid, but it’s not yet known. C1-low PR touches the given topic and has a low impact on builders. and removed A0-please_review Pull request needs code review. labels Jan 7, 2023
@xlc
Copy link
Contributor

xlc commented Jan 7, 2023

Custom RPC is already depercated. We only need the runtime API part.

@gpestana gpestana marked this pull request as draft January 8, 2023 19:08
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2239952

@gpestana
Copy link
Contributor Author

Thanks for the input @xlc, I'm closing this PR in lieu of #13119

@gpestana gpestana closed this Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C1-low PR touches the given topic and has a low impact on builders. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants