Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow duplicate topics in smart contract events #13065

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Allow duplicate topics in smart contract events #13065

merged 3 commits into from
Jan 11, 2023

Conversation

xgreenx
Copy link
Contributor

@xgreenx xgreenx commented Jan 4, 2023

Fixes #12906

Removed the usage of Error::DuplicateTopics.
Removed the has_duplicates check from the deposit_event.

@xgreenx
Removed has_duplicates check form the deposit_event.
1a99f52 
Removed the usage of `Error::DuplicateTopics`.
@xgreenx xgreenx requested a review from athei as a code owner January 4, 2023 14:59
@athei athei added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 10, 2023
@athei
Copy link
Member

athei commented Jan 10, 2023

/cmd queue -c bench-bot $ pallet dev pallet_contracts

@command-bot
Copy link

command-bot bot commented Jan 10, 2023

@athei Could not find matching configuration bench-bot; available ones are bench, fmt, sample, try-runtime.

@athei
Copy link
Member

athei commented Jan 10, 2023

/cmd queue -c bench $ pallet dev pallet_contracts

@command-bot
Copy link

command-bot bot commented Jan 10, 2023 •
edited
Loading

@athei https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247971 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 16-a1628d5b-190b-4cf1-8dc9-ea574684947b to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 10, 2023

@athei Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247971 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2247971/artifacts/download.

@athei
Copy link
Member

athei commented Jan 11, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 2c029fd into paritytech:master Jan 11, 2023
@chevdor chevdor mentioned this pull request Feb 9, 2023
Merged
@EgorPopelyaev EgorPopelyaev added B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. and removed B7-runtimenoteworthy labels Feb 10, 2023
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@xgreenx @ltfschoen
Allow duplicate topics in smart contract events (paritytech#13065)
80fe487 
* Removed `has_duplicates` check form the `deposit_event`.
Removed the usage of `Error::DuplicateTopics`.

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
This was referenced Feb 22, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@kiltbot kiltbot mentioned this pull request Feb 27, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@xgreenx @ark0f
Allow duplicate topics in smart contract events (paritytech#13065)
ec8c480 
* Removed `has_duplicates` check form the `deposit_event`.
Removed the usage of `Error::DuplicateTopics`.

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_contracts

Co-authored-by: command-bot <>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Apr 17, 2023
Closed
6 tasks
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@athei athei athei approved these changes

@xermicus xermicus xermicus approved these changes

@agryaznov agryaznov Awaiting requested review from agryaznov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Smart Contracts
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow duplicate topics emitting by the contract
4 participants
@xgreenx @athei @xermicus @EgorPopelyaev