Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Ignore empty authority changes #13010

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Ignore empty authority changes #13010

merged 1 commit into from
Dec 23, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 22, 2022

When something tries to enact an authority change with an empty authority set, we will ignore this now.

@bkchr
Ignore empty authority changes
7f67739 
When something tries to enact an authority change with an empty authority set, we will ignore this now.
@bkchr bkchr added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Dec 22, 2022
@bkchr
Copy link
Member Author

bkchr commented Dec 22, 2022

This is basically some safe guard against some recent failures we have seen.

melekes
melekes approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (code-wise; don't know enough to reason about business logic)

andresilva
andresilva approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This check could also have been done on the session pallet.

@bkchr
Copy link
Member Author

bkchr commented Dec 23, 2022

LGTM. This check could also have been done on the session pallet.

Let's be generic for people that may use a different session pallet or whatever.

@bkchr bkchr merged commit ed31016 into master Dec 23, 2022
@bkchr bkchr deleted the bkchr-ignore-empty-authorities branch December 23, 2022 22:28
@librelois librelois mentioned this pull request Jan 23, 2023
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Feb 8, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Feb 14, 2023
Merged
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@bkchr @ltfschoen
Ignore empty authority changes (paritytech#13010)
4a645b6 
When something tries to enact an authority change with an empty authority set, we will ignore this now.
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@bkchr @ark0f
Ignore empty authority changes (paritytech#13010)
457ca6c 
When something tries to enact an authority change with an empty authority set, we will ignore this now.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@melekes melekes melekes approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @andresilva @melekes