Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix missing block number issue on forced canonicalization #12949

Merged
merged 5 commits into from
Dec 16, 2022

Commits on Dec 15, 2022

  1. Fix missing block number issue on forced canonicalization

    There is this issue about missing block numbers on forced canonicalization. I looked over the code
    now 10000 times and there are possible ways this can be triggered, but I don't really know how this
    is triggered. So, this pr is going to solve the symptom and not the cause. The block number to hash
    mapping is set when we import a new best block. Forced canonicalization will now stop at the best
    block and it will canonicalize the other blocks later when the best block moved. As the error
    reports indicated that this issue mainly happened on major sync, there should not be any forks, so
    not doing the canonicalization directly shouldn't be that harmful. All known implementations should
    import all blocks as best block on major sync anyway (I mean somewhere there is the bug, but I
    didn't yet found it).
    
    I will also do some changes to Cumulus around some potential culprit for this issue.
    
    Closes: #12613
    bkchr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    08ff1a6 View commit details
    Browse the repository at this point in the history
  2. Add some docs

    bkchr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1ffbbb0 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Fix fix

    bkchr committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    dc60786 View commit details
    Browse the repository at this point in the history
  2. Review comments

    bkchr committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b59a9a0 View commit details
    Browse the repository at this point in the history
  3. Review comments

    bkchr committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    71b87a6 View commit details
    Browse the repository at this point in the history