This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
BlockId removal: refactor: StorageProvider #12510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)
michalkucharczyk
added
A0-please_review
This was referenced Oct 17, 2022
bkchr
approved these changes
Oct 18, 2022
Co-authored-by: Bastian Köcher <git@kchr.de>
dmitry-markin
approved these changes
Oct 18, 2022
altonen
approved these changes
Oct 18, 2022
Co-authored-by: Dmitrii Markin <dmitry@markin.tech>
skunert
approved these changes
Oct 18, 2022
bkchr
approved these changes
Oct 18, 2022
|
bot merge |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* BlockId removal: refactor: StorageProvider It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash` This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292) * Apply suggestions from code review Co-authored-by: Bastian Köcher <git@kchr.de> * Update client/api/src/backend.rs Co-authored-by: Dmitrii Markin <dmitry@markin.tech> * GrandpaBlockImport::current_set_id reworked * ExportStateCmd reworked * trigger CI job * trigger CI job Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Dmitrii Markin <dmitry@markin.tech>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the arguments of
Backend::StorageProvidertrait from:block:
BlockId<Block>to: hash:&Block::HashThis PR is part of BlockId::Number refactoring analysis (paritytech/polkadot-sdk#53)
polkadot companion: paritytech/polkadot#6160
cumulus companion: paritytech/cumulus#1770