This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[Enhancement] Remove optional Pool subscription from fast-unstake #12344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruseinov
added
C1-low
kianenigma
reviewed
Sep 25, 2022
| CurrencyBalance = <Self as pallet_nomination_pools::Config>::CurrencyBalance, | ||
| > + pallet_nomination_pools::Config | ||
| { | ||
| pub trait Config: frame_system::Config + pallet_staking::Config { |
There was a problem hiding this comment.
Later on, you can also tackle another part of #12337 and implement this via trait StakingInterface (if it supports all the needed APIs).
kianenigma
reviewed
Sep 25, 2022
| }; | ||
|
|
||
| let unstake_result = pallet_staking::Pallet::<T>::force_unstake( | ||
| let result = pallet_staking::Pallet::<T>::force_unstake( |
There was a problem hiding this comment.
much simpler now, nice.
kianenigma
approved these changes
Sep 25, 2022
rossbulat
approved these changes
Sep 26, 2022
rossbulat
reviewed
Sep 26, 2022
| CurrencyBalance = <Self as pallet_nomination_pools::Config>::CurrencyBalance, | ||
| > + pallet_nomination_pools::Config | ||
| { | ||
| pub trait Config: frame_system::Config + pallet_staking::Config { |
|
bot merge |
paritytech-processbot
bot
deleted the
ru/enhacement/unstake-remove-pools
branch
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…ritytech#12344) * [Enhancement] Remove optional Pool subscription from fast-unstake * remove nomination-pools pallet dependency * fixes * more fixes * more fixes * more fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #12337