Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Fix] Make sure pool metadata is removed on pool dissolve #12154

Merged
merged 15 commits into from
Sep 6, 2022
Merged

[Fix] Make sure pool metadata is removed on pool dissolve #12154

merged 15 commits into from
Sep 6, 2022

Conversation

ruseinov
Copy link
Contributor

Resolves #12077

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 31, 2022
@ruseinov ruseinov added I3-bug The node fails to follow expected behavior. B7-runtimenoteworthy labels Aug 31, 2022
kianenigma
kianenigma approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kianenigma kianenigma added D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited C1-low PR touches the given topic and has a low impact on builders. labels Sep 1, 2022
@ruseinov ruseinov mentioned this pull request Sep 1, 2022
Merged
@ruseinov
Copy link
Contributor Author

ruseinov commented Sep 1, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@kianenigma
Copy link
Contributor

bot merge cancel

@paritytech-processbot
Copy link

Merge cancelled.

@kianenigma
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Rebased

@kianenigma kianenigma added this to the Polkadot v0.9.29 milestone Sep 5, 2022
ruseinov and others added 4 commits September 5, 2022 18:51
@ruseinov @kianenigma
Update frame/nomination-pools/src/migration.rs
8353a3d 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@ruseinov @kianenigma
Update frame/nomination-pools/src/migration.rs
0b786e4 
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@ruseinov
address comments
70c9f3e
@ruseinov
fix comments
456cbd0
@kianenigma
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Branch is already up-to-date

@kianenigma
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 6bdf4c0 into master Sep 6, 2022
@paritytech-processbot paritytech-processbot bot deleted the ru/fix/dissolve-pool branch September 6, 2022 06:34
@jakoblell jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Sep 8, 2022
@librelois librelois mentioned this pull request Sep 15, 2022
Closed
2 tasks
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@ruseinov @kianenigma @ark0f
[Fix] Make sure pool metadata is removed on pool dissolve (paritytech…
8ea45f9 
…#12154)

* [Fix] Make sure pool metadata is removed on pool dissolve

* add migration

* remove_metadata helper removed

* fix typo and add a comment

* fix pre_upgrade

* fix migration

* Update frame/nomination-pools/src/migration.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* Update frame/nomination-pools/src/migration.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* address comments

* fix comments

* Update frame/nomination-pools/src/migration.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

* address comments

* permissions fix

Co-authored-by: parity-processbot <>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@muharem muharem muharem approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited I3-bug The node fails to follow expected behavior.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
Polkadot v0.9.29
Development

Successfully merging this pull request may close these issues.

nomination-pools: clear pool metadata after a pool is deleted.
4 participants
@ruseinov @kianenigma @muharem @jakoblell